Upgrade transferGas for Staking(BEP153): 2300 -> 5000

chillhacker · January 30, 2023, 9:48am

Hello

Overview:
I suggest increasing the value of “transferGas” for Staking.sol in order to use an upgradable contract as a staker.

Motivation:
Currently, the value of transferGas equals to 2300.
Code reference:

github.com

bnb-chain/bsc-genesis-contract/blob/master/contracts/Staking.sol#L43


      
          
          
// Error code
          uint32 public constant ERROR_WITHDRAW_BNB = 101;
          
          
uint256 public constant TEN_DECIMALS = 1e10;
          uint256 public constant LOCK_TIME = 8 days; // 8*24*3600 second
          
          
uint256 public constant INIT_RELAYER_FEE = 16 * 1e15;
          uint256 public constant INIT_BSC_RELAYER_FEE = 1 * 1e16;
          uint256 public constant INIT_MIN_DELEGATION = 100 * 1e18;
          uint256 public constant INIT_TRANSFER_GAS = 2300;
          
          
uint256 public relayerFee;
          uint256 public bSCRelayerFee;
          uint256 public minDelegation;
          
          
mapping(address => uint256) delegated; // delegator => totalAmount
          mapping(address => mapping(address => uint256)) delegatedOfValidator; // delegator => validator => amount
          mapping(address => uint256) distributedReward; // delegator => reward
          mapping(address => mapping(address => uint256)) pendingUndelegateTime; // delegator => validator => minTime
          mapping(address => uint256) undelegated; // delegator => totalUndelegated

Simple send to smart contract that is deployed using proxy consumes 2747 gas, but Staking.sol allows to use only 2300 gas. It also works with Ethereum since it supports EIP2930(access lists). As a result, there is currently no way to use an upgradable contract as a staker in Staking.sol.

Also a re-entrancy attack makes sense if you can modify storage that costs 5k gas. Setting transferGas value less than 5k gas is safe for you.

zoro · January 30, 2023, 11:05am

Although the staking contract has protection of noRetrancy where we are using transferGas and passing to call. Still let the team test and simulate it with both a custom code and with a proxy contract. Just to estimate how much gas they are consuming in delegate, undelegate, redelgate and claim rewards.

setunapo_NodeReal · February 2, 2023, 11:41am

2300 is not enough, 5000 could be fine, the operation to be executed with 5000 is quite limited.

Striking2112 · April 19, 2023, 6:09pm

Well noted and explained, it will be taken into consideration

Topic		Replies	Views
BEP(Idea): Adjusting Validator Self-Stake Amount within BNB Smart Chain BEP consensus	11	980	April 7, 2023
Utilising BEP-153 to amplify the decentralization of BNB Liquid Staking BEP bep	0	526	June 22, 2023
Greenfield Blockchain Validator Incentivisation Discussion BNB Greenfield	7	564	April 14, 2023
A Proposal for Adopting a lower Transaction Fee Cost on BNB Smart Chain to Enhance Competitiveness BNB Smart Chain consensus , economy	42	10775	June 22, 2023
BEP-319: Optimize the incentive mechanism of the Fast Finality feature	1	345	November 13, 2023

Upgrade transferGas for Staking(BEP153): 2300 -> 5000

Related Topics